Skip to content

fix(sentry/sentry/helper): Redis URL not set when using externalRedis.existingSecret or redis.auth.existingSecret #1871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(sentry/sentry/helper): Redis URL not set when using externalRedis.existingSecret or redis.auth.existingSecret #1871

wants to merge 1 commit into from
+5 −3

Conversation

@jiriks74
Copy link

@jiriks74 jiriks74 commented Sep 5, 2025

Fixes: #1870

@jiriks74 jiriks74 changed the title fix(sentry/sentry/helper): Redis URL not set when using externalRedis and externalRedis.existingSecret fix(sentry/sentry/helper): Redis URL not set when using externalRedis.existingSecret or redis.auth.existingSecret Sep 5, 2025
@jiriks74
Copy link
Author

jiriks74 commented Oct 1, 2025

Hello, seems like this might've been missed. Can I do something to push this further?

@patsevanton
Copy link
Contributor

@jiriks74 could you share minimal values.yaml for reproduce?

@jiriks74
Copy link
Author

jiriks74 commented Oct 26, 2025 •
edited
Loading 

redis:
  enabled: false
externalRedis:
  host: "my-redis"
  port: 6379
  existingSecret: redis-secret
  existingSecretKey: REDIS_PASSWORD
  db: 0
  ssl: false

@jiriks74
Copy link
Author

jiriks74 commented Oct 26, 2025 •
edited
Loading

The issue can be seen in the if statement..

  1. Case: RabbitMQ
  2. Case: Password defined in values 
    {{- else if $redisPass }}
  3. Case: No password 
    {{- else if and (not .Values.externalRedis.existingSecret) (not .Values.redis.auth.existingSecret)}}

There's a missing case for when either externalRedis.existingSecret or redis.auth.existingSecret is set. And because the 3rd case is an if and on those values, once you set at least one of those the broker URL completely disappears and the workers try to connect to localhost instead.

@jiriks74 jiriks74 force-pushed the develop branch 3 times, most recently from 7fa1f42 to 71aefe9 Compare October 26, 2025 08:15
@jiriks74
fix(sentry/sentry/helper): Redis URL not set when using `externalRedi…
ec99b2a 
…s.existingSecret` or `redis.auth.existingSecret`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BUG: BROKER_URL is not set in Sentry configmap if externalRedis.existingSecret or redis.auth.existingSecret is used

2 participants

@jiriks74 @patsevanton